[NFC] Update template get_access call in multi_ptr header
#907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm/llvm-project#80801 updates clang to require a list of template arguments after an identifier prefixed by the template keyword. This change updates a call in `multi_ptr_comparison_op.h` to ensure it compiles with the latest clang. Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
AlexeySachkov
approved these changes
Jul 8, 2024
This was referenced Jul 8, 2024
sarnex
added a commit
to intel/llvm
that referenced
this pull request
Jul 8, 2024
Needed until KhronosGroup/SYCL-CTS#907 is merged Signed-off-by: Sarnie, Nick <[email protected]>
|
@keryell, could you take a look, please? This change blocks a few other PRs. |
sarnex
added a commit
to intel/llvm
that referenced
this pull request
Jul 22, 2024
Fix was [merged](KhronosGroup/SYCL-CTS#907) to CTS. Manual nightly run with this change: https://github.com/intel/llvm/actions/runs/10045951175/job/27765157126 Closes: #14478 Signed-off-by: Sarnie, Nick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project#80801 updates clang to require a list of template arguments after an identifier prefixed by the template keyword. This change updates calls in the
multi_ptrtest headers to ensure they compile with the latest clang.